Skip to content

TIMX 515 - dependency hotfix #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghukill merged 2 commits into from
Aug 14, 2025
Merged

TIMX 515 - dependency hotfix #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec57fa9
Add duckdb_engine and sqlalchemy to build dependencies
ghukill Aug 14, 2025
e8e97b8
Move testing import to TYPE_CHECKING
ghukill Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 58 additions & 58 deletions Pipfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ dependencies = [
"attrs",
"boto3",
"duckdb",
"duckdb_engine",
"pandas",
"pyarrow",
"sqlalchemy"
]

[project.optional-dependencies]
Expand Down
5 changes: 3 additions & 2 deletions timdex_dataset_api/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import boto3
from duckdb.duckdb import DuckDBPyConnection # type: ignore[import-untyped]
from duckdb_engine import ConnectionWrapper
from mypy_boto3_s3.service_resource import S3ServiceResource
from sqlalchemy import (
MetaData,
Table,
Expand All @@ -20,6 +19,8 @@
)

if TYPE_CHECKING:
from mypy_boto3_s3.service_resource import S3ServiceResource

from timdex_dataset_api.dataset import DatasetFilters

logger = logging.getLogger(__name__)
Expand All @@ -31,7 +32,7 @@ def __init__(
) -> None:
self.resource = self._create_resource()

def _create_resource(self) -> S3ServiceResource:
def _create_resource(self) -> "S3ServiceResource":
"""Instantiate a boto3 S3 resource.

If env var MINIO_S3_ENDPOINT_URL is set, assume using local set of MinIO env vars.
Expand Down