Set dc.identifier.oclc for digitized theses item submissions#251
Merged
Conversation
Why these changes are being introduced: * To check if an item already exists in DSpace, the digitized theses workflow will attempt to resolve an object based on this field. How this addresses that need: * The item identifier is set as 'dc.identifier.oclc' Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-1759
jonavellecuerdo
force-pushed
the
IN-1759-digitized-theses-testing
branch
from
94ef19b to
a54a121
Compare
Coverage Report for CI Build 27957416338Warning No base build found for commit Coverage: 83.446%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
ehanson8
approved these changes
Jun 22, 2026
| @property | ||
| def subject(self) -> str: | ||
| return f"DSC Submit Results - {self.workflow_name}, batch='{self.batch_id}'" | ||
| return f"[{CONFIG.workspace}] DSC Submit Results - {self.workflow_name}, batch='{self.batch_id}'" # noqa: E501 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
To check if an item already exists in DSpace, the digitized theses workflow will attempt to resolve an object based on the
dc.identifier.oclcfield.Note: This step is separate from validating "replacement" theses, which continues to rely on a target string identifying "student-submitted electronic theses".
How can a reviewer manually see the effects of these changes?
The issue was noted when I began testing in Stage. Since Stage and Dev both point to the test instance of DSpace, I expected all item submissions to be flagged as "replacement" theses since any "new" theses would've been created via testing in Dev. However, as the attached CSV file shows, this was not the case: 20260611-20260622T124016Z-item-submissions.csv.
Results from updates:
batch_id=20260611through the DSO workflow. This time, items with thedc.identifier.oclcmetadata field will be created for "new" theses:20260611-20260622T134853Z-item-submissions.csv; 55 new theses and 7 replacement theses. This is expected.
batch_id=20260611through the DSO workflow a second time. This yields different results:20260611-20260622T140712Z-item-submissions.csv, now categorizing all 62 items as replacement theses.
Includes new or updated dependencies?
YES - Updated dependencies to resollve CVEs.
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review