Updates post testing digitized theses workflow#246
Merged
Conversation
Coverage Report for CI Build 27700062789Warning No base build found for commit Coverage: 83.438%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Why these changes are being introduced: * Testing of the new digitized theses workflow in Dev revealed the need for these changes. How this addresses that need: * Fix Makefile * Set `aws s3 sync` logging to DEBUG level * Ensure metadata transformer uses `mit.thesis.degree` metadata field * Set collection handles for MIT Theses collections * Fix filename for Alma XML file export Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-1759
edc4fc3 to
4a6cf05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Testing of the new digitized theses workflow in Dev revealed the need for these changes.
How can a reviewer manually see the effects of these changes?
The latest code updates are validated through the successful test run of the new digitized theses DSC workflow: see Jira ticket IN-1759
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review