Skip to content

Updates post testing digitized theses workflow#246

Merged
jonavellecuerdo merged 1 commit into
mainfrom
IN-1759-digitized-theses-testing
Jun 17, 2026
Merged

Updates post testing digitized theses workflow#246
jonavellecuerdo merged 1 commit into
mainfrom
IN-1759-digitized-theses-testing

Conversation

@jonavellecuerdo

Copy link
Copy Markdown
Contributor

Purpose and background context

Testing of the new digitized theses workflow in Dev revealed the need for these changes.

How can a reviewer manually see the effects of these changes?

The latest code updates are validated through the successful test run of the new digitized theses DSC workflow: see Jira ticket IN-1759

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

Code review

  • Code review best practices are documented here and you are encouraged to have a constructive dialogue with your reviewers about their preferences and expectations.

@jonavellecuerdo jonavellecuerdo requested a review from a team as a code owner June 17, 2026 15:21
@coveralls

coveralls commented Jun 17, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 27700062789

Warning

No base build found for commit ced9ae1 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 83.438%

Details

  • Patch coverage: 10 of 10 lines across 3 files are fully covered (100%).

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 2065
Covered Lines: 1723
Line Coverage: 83.44%
Coverage Strength: 0.83 hits per line

💛 - Coveralls

Why these changes are being introduced:
* Testing of the new digitized theses workflow in
Dev revealed the need for these changes.

How this addresses that need:
* Fix Makefile
* Set `aws s3 sync` logging to DEBUG level
* Ensure metadata transformer uses `mit.thesis.degree` metadata field
* Set collection handles for MIT Theses collections
* Fix filename for Alma XML file export

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1759
@jonavellecuerdo jonavellecuerdo force-pushed the IN-1759-digitized-theses-testing branch from edc4fc3 to 4a6cf05 Compare June 17, 2026 15:24
@jonavellecuerdo jonavellecuerdo requested a review from ehanson8 June 17, 2026 15:26

@ehanson8 ehanson8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonavellecuerdo jonavellecuerdo merged commit eba7f1e into main Jun 17, 2026
6 checks passed
@jonavellecuerdo jonavellecuerdo deleted the IN-1759-digitized-theses-testing branch June 17, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants