new: [OIDC] OIDC_LOGIN_TEXT to customise the login button label#422
new: [OIDC] OIDC_LOGIN_TEXT to customise the login button label#422cln-io wants to merge 1 commit into
Conversation
|
basically all work was done by claude |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3814682fed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cln-io
force-pushed
the
feature/oidc-login-button-text
branch
from
3814682 to
8215b59
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8215b5961a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cln-io
force-pushed
the
feature/oidc-login-button-text
branch
from
8215b59 to
ac9b9a5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac9b9a5a02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add an optional OIDC_LOGIN_TEXT environment variable that sets the OidcAuth.login_button_text MISP config value, used to customise the label of the OIDC login button shown when OIDC_MIXEDAUTH is enabled. Only applied when set, so behaviour is unchanged by default. Follows the same pattern as the other OIDC_* variables in set_up_oidc(). Requires the companion MISP change that reads OidcAuth.login_button_text in app/View/Users/login.ctp (defaults to "Login with OIDC").
cln-io
force-pushed
the
feature/oidc-login-button-text
branch
from
ac9b9a5 to
9a08895
Compare
1 participant
What does it do?
Adds an optional
OIDC_LOGIN_TEXTenvironment variable that sets theOidcAuth.login_button_textMISP config value, customising the label of the OIDC login button shown on the login page whenOIDC_MIXEDAUTHis enabled.Companion to MISP/MISP#10825, which adds the
OidcAuth.login_button_textsetting read byapp/View/Users/login.ctp(defaulting to "Login with OIDC"). This PR is a no-op until that change is merged and a newmisp-coreimage is built.Implemented in
set_up_oidc()following the exact same pattern as the otherOIDC_*variables (e.g.OIDC_SCOPES,OIDC_LOGOUT_URL): only applied when set, so behaviour is unchanged by default.Changes:
core/files/configure_misp.sh— writeOidcAuth.login_button_textfromOIDC_LOGIN_TEXTwhen the variable is set.template.env— document the new (commented) variable next toOIDC_MIXEDAUTH.Questions
OidcAuth.*value intoconfig.phpviamodify_config.php, like the other OIDC settings.Depends on: MISP/MISP#10825