chore: cleanup VirtioFS workarounds, parameterize PHP version, add Makefile, and fix minor issues #421
Merged
Merged
Conversation
ostefano
force-pushed
the
fix/virtio-rebased
branch
4 times, most recently
from
6dc21be to
00e1517
Compare
ostefano
changed the title
Collaborator
Author
|
Additional changes:
|
ostefano
force-pushed
the
fix/virtio-rebased
branch
from
00e1517 to
86d250d
Compare
ostefano
force-pushed
the
fix/virtio-rebased
branch
from
86d250d to
6b7e975
Compare
docs(readme): add docker hub note for pulling dependencies and base images fix: add safe_sed_i helper and replace VirtioFS workarounds - Add safe_sed_i() function using mktemp+cat pattern to replace the fragile sed > tmp; cat tmp > file; rm tmp workaround used for VirtioFS compatibility (Docker Desktop for Mac) - Replace dd if=... of=... initial file copies with cat ... > ... for clearer intent - Remove deprecated VirtioFS workaround comments referencing the Docker forum bug report feat: parameterize hardcoded PHP 8.4 references via build arg - Add PHP_PACKAGE_VERSION build arg (default 8.4) to core/Dockerfile - Replace all php8.4 package names, binary paths, and config refs with php for single-point-of-change upgrades - Create /usr/local/sbin/php-fpm symlink so entrypoint scripts use php-fpm instead of hardcoded versioned binary paths - Use @PHP_VERSION@ placeholder in nginx config, templated at build time via sed - Pass PHP_PACKAGE_VERSION to docker-compose build args - Update entrypoint_fpm.sh and kubernetes/entrypoint_fpm.sh to use the version-agnostic php-fpm command feat: add Makefile for common build and runtime tasks Provides convenient targets for the most frequent operations: - build, build-core, build-modules, build-guard, build-slim, bake - up, down, logs for runtime management - shellcheck, clean, prune for maintenance - help target as default to list available commands fix: restore AUTOCONF_ADMIN_KEY backward compat with cleaner pattern Now uses a single export line that expands AUTOCONF_ADMIN_KEY as an inline fallback, keeping backward compat for users with AUTOCONF_ADMIN_KEY in their .env files.
ostefano
force-pushed
the
fix/virtio-rebased
branch
from
6b7e975 to
9b48ac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes this: #417
CC @mortezamirkar