Remove unused _version.py references#160
Conversation
There was a problem hiding this comment.
@orbeckst since we are deleting the only line in this file, I think it's best to fully delete .gitattributes with git rm but would prefer to confirm this is the right way to go.
|
Can you check that we’re not actually having versioningit write _version.py? See https://versioningit.readthedocs.io/en/stable/runtime-version.htmlAm 5/9/26 um 16:24 schrieb Estefania Barreto-Ojeda ***@***.***>:
@ojeda-e commented on this pull request.
On {{cookiecutter.repo_name}}/.gitattributes:
@orbeckst since we are deleting the only line in this file, I think it's best to fully delete .gitattributes with git rm but would prefer to confirm this is the right way to go.
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
It seems like we are not. Yes, we do use versioningit, but we do not write the version down to cookiecutter-mdakit/{{cookiecutter.repo_name}}/pyproject.toml Lines 62 to 74 in 37f59bb Meaning, the version string is obtained from git. It does not, by itself, create a Following the versiongit docs, if we were writing the version down to [tool.versioningit.write]
file = "src/project_name/_version.pyBut nothing in the pyproject.toml indicates we are doing so. |
orbeckst
left a comment
There was a problem hiding this comment.
Looks good. I agree with you to delete the .gitattributes. Please do and then we can merge. I am just approving ahead of time.
|
@orbeckst file deleted; this PR is ready to merge. |
|
Thank you! |
Fixes #144
Changes made in this Pull Request:
Removed references from the following files
Updated documentation (fix typos and updated info) in:
PR Checklist