-
Notifications
You must be signed in to change notification settings - Fork 7
Fix: build docs by setting repo_name as project_name to #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
474f441
Fix: set repo_name from project_name
ojeda-e a4e2d83
Add tests - project name matches
ojeda-e 2f03eb9
Chore: Update AUTHORS and CHANGELOG
ojeda-e db48d07
Set same name as in ExampleRepositoryDocumentation
ojeda-e bf3c1d9
Update CHANGELOG.md: typo fix
orbeckst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| """Tests for docs/scripts/generate_cookiecutter_cli helpers.""" | ||
|
|
||
| import pathlib | ||
| import sys | ||
|
|
||
| import pytest | ||
|
|
||
| _DOCS_SCRIPTS = pathlib.Path(__file__).resolve().parents[1] / "docs" / "scripts" | ||
| sys.path.insert(0, str(_DOCS_SCRIPTS)) | ||
|
|
||
| from generate_cookiecutter_cli import repo_name_from_project_name # noqa: E402 | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ("project_name", "expected_repo_name"), | ||
| [ | ||
| ("A Project Name", "a_project_name"), | ||
| ("same_name_as_project", "same_name_as_project"), | ||
| ("Test-Project Name", "test_project_name"), | ||
| ], | ||
| ) | ||
| def test_repo_name_from_project_name_matches_cookiecutter_default( | ||
| project_name: str, | ||
| expected_repo_name: str, | ||
| ) -> None: | ||
| """Mirrors ``repo_name`` in cookiecutter.json (slug from ``project_name``).""" | ||
| assert repo_name_from_project_name(project_name) == expected_repo_name |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be overkilling it with this. IMO when in doubt, better add a test.