manually set version to current MDA release 2.10.0#155
Conversation
|
I looked for more details here, and definitely the quotes for mda version is not the root of the problem. It traces back to the file cookiecutter-mdakit/docs/scripts/generate_cookiecutter_cli.py Lines 114 to 117 in 2856a05 As an attempt to find a reference, I checked and the |
|
This script was added by us, see https://github.com/MDAnalysis/cookiecutter-mdakit/blame/main/docs/scripts/generate_cookiecutter_cli.py — @lilyminium to be precise. I don't know what these scripts are doing. |
|
After more investigation, I opened an issue with a detailed description of what I found: If there are no objections, I can work on this. |
Co-authored-by: Estefania Barreto-Ojeda <estefania.b.ojeda@gmail.com>
|
This PR does not really fix #141 but just changes the number to something somewhat more sensible in the meantime. |
|
Ping @lilyminium @IAlibay @p-j-smith (cookiecutter team) — are you ok with at bumping the recorded/displayed version of the cookiecutter to the current MDA release? Or would you rather we remove it completely although I haven't looked where it plays a role and I probably won't be able to invest a lot of time into this PR. |
|
Sorry for the delay, I was away on my honeymoon and couldn't figure out if GitHub had vacation settings! When we/I set this up we intended the cookiecutter to be versioned separately to MDA proper as we anticipated MDA being updated in accordance to new science/functionality and the cookiecutter to be updated in accordance to best practices in Python development, which moves a bit slower. Updating the cookiecutter every time the core library gets updated is a bit of additional work, whereas I think removing versioning largely keeps things the same, so I would vote for the latter over the former. Is anything actively breaking at the moment from the version mismatch? |
I don't think so. It's just that the version number 0.1 is baked into the docs of every single MDAKit that uses it and it conveys no information (or is confusing because it may seem that nothing in the cookiecutter changed). I am also not fully convinced that using the latest MDA version is particularly helpful, except in that we have an idea that it worked with it. For right now, I'll close the PR and we can decide on the issue #141 how to proceed. |

Related to #141
Changes made in this Pull Request:
PR Checklist