Update channels to be more specific#143
Conversation
| name: {{cookiecutter.repo_name}}-test | ||
| channels:{% if cookiecutter.dependency_source == 'Prefer conda-forge over the default anaconda channel with pip fallback' %} | ||
| - conda-forge{% endif %} | ||
| channels:{% if cookiecutter.__dependency_source == 'anaconda' %} |
There was a problem hiding this comment.
If I'm understanding this properly, if this case happens then the channel will be set to default and won't have conda-forge? If that's the case, they won't be able to download MDAnalysis so it stops being an mdakit.
There was a problem hiding this comment.
Good catch. I had been going to move MDA to the pip downloads but hadn't yet -- firstly need to figure out how to test this 😅
There was a problem hiding this comment.
I'm not sure that offering the combination of a mixed pip + conda install is a good idea. i.e. it's what I would consider bad practice.
AFAIK there are nearly no cases where one has something in defaults that isn't in conda-forge - why even keep it around?
There was a problem hiding this comment.
Let's not offer anaconda == defaults and instead just keep conda-forge around (or just pypi).
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
Let's completely remove the option to choose anaconda (=defaults).
| name: {{cookiecutter.repo_name}}-test | ||
| channels:{% if cookiecutter.dependency_source == 'Prefer conda-forge over the default anaconda channel with pip fallback' %} | ||
| - conda-forge{% endif %} | ||
| channels:{% if cookiecutter.__dependency_source == 'anaconda' %} |
There was a problem hiding this comment.
Let's not offer anaconda == defaults and instead just keep conda-forge around (or just pypi).
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
That required a lot of edits! Thank you! From what I can see, lgtm.
3 participants
Fixes #142
Changes made in this Pull Request:
PR Checklist