Fix: connecting a server no longer un-toggles your other servers

[ignaciojimenezr]

• When you connect a server, the app used to reset your server toggles to match your active Client's saved server list. Any server you'd switched on by hand got switched off — even though it stayed connected (still green in the dashboard). The toggle just silently flipped off.

• Why it happened: connecting a server can make the active Client's required-server list re-resolve, and the code replaced your whole selection with that list, dropping anything you'd added manually.

• The fix: switching to a different Client still snaps the selection to that Client's servers (unchanged). But within the same Client, re-resolving the list now merges in what's needed instead of replacing — so your manual toggles are never wiped.

• Added a regression test covering the exact case: a manually-toggled server survives connecting another server.

Screen.Recording.2026-05-27.at.7.15.54.PM.mov

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[chelojimenez]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

Walkthrough

This PR refactors useAutoConnectProjectServers to preserve user-selected servers within a project scope. Instead of replacing the selection whenever requiredNames changes, the hook now seeds selection only when entering a new project scope, then merges subsequent required-server updates into the existing selection. Module-scoped refs track the latest selection state and which scope was last seeded. A regression test verifies that manually selected servers persist and merge with newly required servers when requiredNames updates mid-session.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Internal preview

Preview URL: https://mcp-inspector-pr-2298.up.railway.app
Deployed commit: 80c2bdd
PR head commit: 2508374
Backend target: staging fallback.
Health: ❌ Convex unreachable — see upsert-preview job logs (staging may need convex deploy)
Access is employee-only in non-production environments.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

mcpjam-inspector/client/src/App.tsx (1)

2758-2790: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Scope runtime-expanded server list to Playground-only here.

Line 2764 currently feeds displayServerConfigs into both App Builder and Playground selectors; App Builder is single-select and still resolves core selected config from catalog-backed state, so runtime-only entries can become selectable before they are resolvable.

Suggested patch

   const playgroundServerSelectorProps = useMemo(():
     | PlaygroundServerSelectorProps
     | undefined => {
     if (activeTab !== "app-builder" && activeTab !== "playground")
       return undefined;
     return {
-      serverConfigs: displayServerConfigs,
+      serverConfigs:
+        activeTab === "playground" ? displayServerConfigs : projectServers,
       selectedServer: appState.selectedServer,
       selectedMultipleServers: appState.selectedMultipleServers,
@@
   }, [
     activeTab,
     displayServerConfigs,
+    projectServers,
     appState.selectedServer,
     appState.selectedMultipleServers,

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@mcpjam-inspector/client/src/App.tsx` around lines 2758 - 2790,
playgroundServerSelectorProps currently passes displayServerConfigs to both App
Builder and Playground, allowing runtime-only (catalog-less) entries to be
selectable in App Builder; change the serverConfigs value in
playgroundServerSelectorProps so only the Playground receives the
runtime-expanded list and App Builder receives a catalog-backed list (e.g., when
activeTab === "playground" use displayServerConfigs, otherwise pass a
filtered/alternative list that excludes runtime-only entries). Update the
serverConfigs expression in the playgroundServerSelectorProps useMemo (and keep
isMultiSelectEnabled based on activeTab) so App Builder never gets runtime-only
configs.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@mcpjam-inspector/client/src/App.tsx`:
- Around line 2758-2790: playgroundServerSelectorProps currently passes
displayServerConfigs to both App Builder and Playground, allowing runtime-only
(catalog-less) entries to be selectable in App Builder; change the serverConfigs
value in playgroundServerSelectorProps so only the Playground receives the
runtime-expanded list and App Builder receives a catalog-backed list (e.g., when
activeTab === "playground" use displayServerConfigs, otherwise pass a
filtered/alternative list that excludes runtime-only entries). Update the
serverConfigs expression in the playgroundServerSelectorProps useMemo (and keep
isMultiSelectEnabled based on activeTab) so App Builder never gets runtime-only
configs.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b1438205-d565-4342-a873-47ce66f1a3bc

📥 Commits

Reviewing files that changed from the base of the PR and between 42b3178 and 24e318f.

📒 Files selected for processing (3)

• mcpjam-inspector/client/src/App.tsx
• mcpjam-inspector/client/src/hooks/use-app-state.ts
• mcpjam-inspector/client/src/hooks/use-server-state.ts