Skip to content

Remove Playground announcement popover#2293

Open
chelojimenez wants to merge 1 commit into
mainfrom
claude/gifted-hamilton-65f47a
Open

Remove Playground announcement popover#2293
chelojimenez wants to merge 1 commit into
mainfrom
claude/gifted-hamilton-65f47a

Conversation

@chelojimenez
Copy link
Copy Markdown
Contributor

@chelojimenez chelojimenez commented May 27, 2026

Summary

  • Drop the one-time "Playground just got more powerful" announcement attached to the Playground sidebar item in mcp-sidebar.tsx. The popover has served its purpose and shouldn't keep showing up for new users.

Test plan

  • Reset the dismissal localStorage key (mcpjam:announcement-dismissed:playground-tab-rename-2026-05) and confirm no announcement popover appears next to Playground in the sidebar.
  • Verify the Playground sidebar item still navigates correctly with the playground-tab-enabled flag on.

🤖 Generated with Claude Code


Note

Low Risk
Sidebar-only config removal with no routing, auth, or data changes.

Overview
Removes the one-time Playground sidebar announcement (playground-tab-rename-2026-05) that showed a NEW badge and popover about App Builder capabilities being merged into Playground.

The Playground nav entry is unchanged aside from dropping the announcement config; routing and the playground-tab-enabled flag behavior stay the same.

Reviewed by Cursor Bugbot for commit f25b32a. Bugbot is set up for automated code reviews on this repo. Configure here.

The one-time announcement popover next to the Playground sidebar item
has run its course; remove it so new users don't see a stale "NEW" badge.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 27, 2026
@chelojimenez
Copy link
Copy Markdown
Contributor Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d103bfa8-1b82-4c2f-8489-115b8bdf57c1

📥 Commits

Reviewing files that changed from the base of the PR and between 01e4a1e and f25b32a.

📒 Files selected for processing (1)
  • mcpjam-inspector/client/src/components/mcp-sidebar.tsx
💤 Files with no reviewable changes (1)
  • mcpjam-inspector/client/src/components/mcp-sidebar.tsx

Walkthrough

This PR removes the "Playground just got more powerful" announcement from the Playground sidebar navigation item. The change eliminates the announcement object that previously rendered a NEW badge and popover notification, with no impact to other navigation structure or component exports.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f25b32a. Configure here.

url: "/playground",
icon: MessageCircle,
featureFlag: "playground-tab-enabled",
announcement: {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Announcement infrastructure now entirely unused dead code

Low Severity

The removed Playground announcement was the only consumer of the announcement field on NavItem, the AnnouncementNavRow component, the NavMainItemAnnouncement type, the useDismissibleAnnouncement hook import, and the Popover/Badge/Button imports in nav-main.tsx. All of this code (~70 lines plus a hook file) is now dead. Cleaning it up in the same PR would keep the codebase tidy and avoid confusing future maintainers.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f25b32a. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

Internal preview

Preview URL: https://mcp-inspector-pr-2293.up.railway.app
Deployed commit: aa0713d
PR head commit: f25b32a
Backend target: staging fallback.
Health: ❌ Convex unreachable — see upsert-preview job logs (staging may need convex deploy)
Access is employee-only in non-production environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant