Release: develop → master#4
Merged
Merged
Conversation
A firm shop's sign owner is its Treasury account (B:<accountId>). Disband archives that account and removes its firm link, so the CHESTSHOP-permission gate in onAccountAccess always fails — leaving the shop unremovable. Grant access when no live firm owns the account (getFirmByAccountId == null), i.e. the firm was disbanded, so the orphaned shop can be cleaned up. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
🔗 Linked to PAR-29 — players can't remove chestshops belonging to a disbanded firm Status: Posted by tesks · this PR moves the issue as it opens/merges. |
Coverage report
|
Our fork supports Bedrock via Floodgate, but ChestShop's stock defaults block it: VALID_PLAYERNAME_REGEXP=^\w+$ rejects '.'-prefixed names (so a Bedrock player can't buy/sell or own a shop) and ENSURE_CORRECT_PLAYERID=true rejects their non-v4 UUIDs. Default the regex to ^\.?\w+$ (optional leading Floodgate prefix) and ENSURE_CORRECT_PLAYERID to false so Bedrock works out of the box. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release:
develop→master(ChestShop-3)DC-specific fork release. Reviewing for bugs/regressions before merge.
Issues in this release
Review focus
TreasuryListener.onAccountAccessnow grants access whenbusinessApi.firms().getFirmByAccountId(accountId) == null— i.e. the firm account no longer maps to a live firm (disbanded →firm_accountlink removed). Confirm this can't unintentionally unlock a still-valid firm shop.🤖 Generated with Claude Code