Conversation
Daisy-bit
pushed a commit
to Daisy-bit/MASLab
that referenced
this pull request
May 25, 2026
…rate eigenvalue
P1 fixes (real / experiment-impacting bugs):
* mad_scc code task: `_vote`/`_group_for_diag` now uses body-stripped BLEU
for clustering (matches scc_components.voting._code_bleu_plurality).
Previously full-code BLEU was used, so trigger (count_first_plurality,
body-stripped) and vote (_group_for_diag, full-code) could disagree on
cluster membership when agents used same logic with different
docstrings. Verified: two `def add(a,b)` with different docstrings
now correctly cluster as one group.
* inference.py --sequential: process_sample() was called with 4 args but
the function signature requires 5 (lock missing). Sequential mode
crashed with TypeError immediately. Added the missing lock arg.
* pc1_contributions: when all embeddings are identical, S_c ≈ 0 and eigh
picks an arbitrary orthonormal basis. The leading "eigenvector" carries
no information, but softmax(|v_1|) would give one random agent ~100%
weight. Now detects raw_lam1 < 1e-10 and returns uniform 1/N.
Verified: 5 identical embs now yield [0.2]*5 instead of [~1, ~0, ~0, ~0, ~0].
P2 fixes (consistency):
* mad_scc/soo_scc pool-size handling unified to `>=`. mad_scc previously
required strict equality (rejected oversized pools), soo_scc accepted
and sliced. Now both accept `>=` and use the first N entries.
* task_typing._MCQ_SOURCES now includes aqua-rat, medmcqa, medqa.
Previously these relied on the option-pattern fallback in
_query_looks_like_mcq, which has false-positive risk for math
problems mentioning "(A)" patterns.
Round 3 P3+ findings deferred per "只修 P1 三条 + P2 顺手两条" decision:
R1-MASWorks#2/MASWorks#3/MASWorks#4/MASWorks#7/MASWorks#8, R2-M2/M3/M6/M7/M8/M9/M10, R3-C2/C3/C5/C6.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.