refactor(logo): rebuild M2 mark in refined brand green from a single source#27
Merged
Conversation
…source Regenerate every logo asset from one source of truth so the in-app mark and the Windows app icon are pixel- and color-consistent. - scripts/build_logo.py: dependency-free (Pillow only) logo builder. Extracts the exact M2 path from the in-app gh-icon SVG in index.html, reproduces the SVG even-odd fill (ring + monogram holes) by XOR-ing each sub-path mask, renders at 4x supersample, and emits SVG + PNG + multi-size ICO. Brand green is defined once (BRAND_GREEN = #16A34A) and overridable via CLI arg. - LOGO/M2_SCOUT.ico: rebuilt in #16A34A. Removes the old dull #008800 and the stray white pixels; now a single clean brand green across all 6 sizes. - LOGO/M2_SCOUT.svg, LOGO/M2_SCOUT.png: new vector source + 256px preview. - style.css: the in-app gh-icon now uses the fixed brand green (#16A34A, hover #22C55E) instead of theme colors, so it always matches the app icon.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuilds the M2 brand mark in a refined, vivid green and regenerates every
logo asset from a single source of truth, so the in-app mark and the Windows
app/installer/taskbar icon are pixel- and color-consistent.
The previous
M2_SCOUT.icowas a dull web-green (#008800) and carried strayopaque white pixels. It is replaced with a clean, single brand green
(
#16A34A) across all sizes.What changed
scripts/build_logo.pygh-iconSVG inindex.html, reproduces the SVG even-odd fill (ring + monogram holes) by XOR-ing each sub-path mask, renders at 4× supersample, and emits SVG + PNG + multi-size ICO. Brand green is defined once (BRAND_GREEN = #16A34A).LOGO/M2_SCOUT.ico#16A34A. All 6 sizes (16/32/48/64/128/256), single clean green, no stray white.LOGO/M2_SCOUT.svgLOGO/M2_SCOUT.pngsrc/renderer/css/style.cssgh-iconnow uses the fixed brand green (#16A34A, hover#22C55E) instead of theme colors, so it always matches the app icon.Consistency
All three rendered assets (in-app SVG,
.ico,.png) derive from the same M2path and the same green constant. To re-color, run:
and update the two
#16A34A/#22C55Eliterals instyle.css.Testing
python scripts/build_logo.py→ builds SVG/PNG/ICO; ICO verified to containall 6 sizes with
#16a34aas the only opaque color (no stray white).npm test→ 5 pass / 0 fail (includes thegh-iconinline-SVG check).Notes
#16A34A(reads well on light and dark taskbars).Easy to change via the script + two CSS literals.
README.mdonly referencesLOGO/M2_SCOUT.ico(path unchanged), so no docedits were needed.