Skip to content

fix(release): single multi-arch build, fixes failed v0.2.1 publish#67

Merged
oahsiao merged 2 commits into
mainfrom
fix/ci-release-publish-never
Jun 24, 2026
Merged

fix(release): single multi-arch build, fixes failed v0.2.1 publish#67
oahsiao merged 2 commits into
mainfrom
fix/ci-release-publish-never

Conversation

@oahsiao

@oahsiao oahsiao commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

The v0.2.1 release build failed with GitHub Personal Access Token is not set.

Cause: the 0.2.1 dist chained two electron-builder calls (--x64 then --arm64), each with --publish never. The release workflow also ran npm run dist -- --publish never; npm appends that to the last call, giving it --publish twice. Duplicated flags parse as an array (["never","never"]), which electron-builder no longer treats as never -> it auto-published on the tag and failed (no GH_TOKEN). The --x64 call had it once, so only --arm64 failed.

Fix (mirrors the proven M2Station/M2_LOG setup):

  • dist is now a single call: electron-builder --win --x64 --arm64.
  • --publish never is applied once by the workflow step.
  • artifactName moved to win level: \ Setup \ \.\.

Output (verified locally with the exact CI command): combined + per-arch installers, same as M2_LOG -
M2_GIT_DIFF Setup 0.2.1.exe (x64+arm64), ... x64.exe, ... arm64.exe.

OA Hsiao added 2 commits June 24, 2026 18:24
The dist script now runs electron-builder once per arch and already passes --publish never to each. The release workflow also appended '-- --publish never', which npm adds to the last invocation, giving it --publish twice. Duplicated flags parse as an array that electron-builder no longer treats as 'never', so it auto-published on the tag and failed with no GH_TOKEN. Use plain 'npm run dist'.
…_LOG)

Two chained electron-builder calls + the workflow's '-- --publish never' gave the last call --publish twice. A duplicated flag parses as an array, so electron-builder ignored 'never' and tried to auto-publish on the tag, failing with no GH_TOKEN.

Use one 'electron-builder --win --x64 --arm64' call (like M2Station/M2_LOG), with --publish never applied once by the workflow. Produces combined + per-arch installers (x64, arm64).
@oahsiao oahsiao changed the title fix(ci): release build attempts publish (duplicate --publish never) fix(release): single multi-arch build, fixes failed v0.2.1 publish Jun 24, 2026
@oahsiao oahsiao merged commit 6cc9865 into main Jun 24, 2026
6 checks passed
@oahsiao oahsiao deleted the fix/ci-release-publish-never branch June 24, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant