Skip to content

refactor: cleanup MLP implementation#155

Merged
avik-pal merged 8 commits into
mainfrom
ap/cleanup_mlp
Sep 18, 2025
Merged

refactor: cleanup MLP implementation#155
avik-pal merged 8 commits into
mainfrom
ap/cleanup_mlp

Conversation

@avik-pal

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @avik-pal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refactoring the Multi-Layer Perceptron (MLP) implementation to enhance its usability and internal structure. It introduces a more flexible way to define hidden layer dimensions by accepting a vector input, and significantly simplifies the internal block construction by removing an unnecessary wrapper, leading to cleaner and potentially more efficient code.

Highlights

  • Version Update: The package version in Project.toml has been incremented from 1.7.0 to 1.7.1.
  • MLP Constructor Enhancement: A new constructor for the MLP layer has been added, allowing hidden_dims to be specified as a Vector{<:Integer} for improved flexibility.
  • Code Simplification: The DenseNormActDropoutBlock wrapper struct has been removed, and the dense_norm_act_dropout function now directly returns Lux.Dense or Lux.Chain instances, simplifying the internal architecture.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the MLP implementation, which is a good cleanup. The primary changes involve removing the DenseNormActDropoutBlock wrapper for a simpler design that returns Lux layers directly, and adding a new convenience constructor for MLP that accepts a Vector for hidden layer dimensions. These changes improve the code's simplicity and usability. I have one suggestion to further refactor the dense_norm_act_dropout function to improve its conciseness and maintainability.

Comment thread src/layers/mlp.jl Outdated
@avik-pal

Copy link
Copy Markdown
Member Author

overloaded_map fixed by EnzymeAD/Reactant.jl#1665

@avik-pal avik-pal merged commit ce12052 into main Sep 18, 2025
11 of 13 checks passed
@avik-pal avik-pal deleted the ap/cleanup_mlp branch September 18, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant