Update nix.md#3
Conversation
switch to systemd service from docker
|
Thank you very much, apologies for the slow response! |
jzohrab
left a comment
There was a problem hiding this comment.
Not requesting changes, but a few points for discussion with @christhepanda28 . Thanks very much for taking the time to move this forward!
| hatchling | ||
| hatch-vcs | ||
| ]; | ||
| meta = with pkgs.lib; { |
There was a problem hiding this comment.
This looks interesting. A few questions:
- Instead of pulling in dependencies here, should this script instead use the lute3 pypi package directly? That pypi package has all of the dependencies listed in it, and the pip install of lute pulls everything correctly. That means less duplication here.
- If using the lute3 pypi package isn't possible, then If new pypi packages are added to Lute, how would this section be kept current, do you think? i.e. should there be a build step in the Lute build/CI tests to check that it installs correctly? If yes, then perhaps this code is really code that should be moved into the lute-v3 repo somewhere, and a build step done to check it.
There was a problem hiding this comment.
it does use the pypi version of lute, but in nix, build steps are not allowed to access the internet, so all dependencies need to be pre-fetched. the other python packages are all dependencies for lute not currently packaged in nixpkgs. new dependencies are added in the same way. (if packaged in nix, just package name in propagatedBuildInputs, otherwise a package definition with -pkg to signify it is packaged here and not in nixpkgs.
for updating, all that is needed is to change the version name, nix will recognise the hash is wrong and give the correct hash to put in, and then it should work fine. if you want this in the main repo, I can write something for that too.
There was a problem hiding this comment.
Sorry again for tardiness, @christhepanda28 . I appreciate the notes and think that this is a great start, so will merge it. Appreciated!
switch to systemd service from docker, with nix-managed dependencies.