Skip to content

Update nix.md#3

Merged
jzohrab merged 1 commit into
LuteOrg:masterfrom
christhepanda28:patch-3
Aug 15, 2025
Merged

Update nix.md#3
jzohrab merged 1 commit into
LuteOrg:masterfrom
christhepanda28:patch-3

Conversation

@christhepanda28

Copy link
Copy Markdown
Contributor

switch to systemd service from docker, with nix-managed dependencies.

switch to systemd service from docker
@jzohrab

jzohrab commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

Thank you very much, apologies for the slow response!

@jzohrab jzohrab self-requested a review July 18, 2025 01:04

@jzohrab jzohrab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not requesting changes, but a few points for discussion with @christhepanda28 . Thanks very much for taking the time to move this forward!

Comment thread src/setup/nix.md
hatchling
hatch-vcs
];
meta = with pkgs.lib; {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks interesting. A few questions:

  • Instead of pulling in dependencies here, should this script instead use the lute3 pypi package directly? That pypi package has all of the dependencies listed in it, and the pip install of lute pulls everything correctly. That means less duplication here.
  • If using the lute3 pypi package isn't possible, then If new pypi packages are added to Lute, how would this section be kept current, do you think? i.e. should there be a build step in the Lute build/CI tests to check that it installs correctly? If yes, then perhaps this code is really code that should be moved into the lute-v3 repo somewhere, and a build step done to check it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does use the pypi version of lute, but in nix, build steps are not allowed to access the internet, so all dependencies need to be pre-fetched. the other python packages are all dependencies for lute not currently packaged in nixpkgs. new dependencies are added in the same way. (if packaged in nix, just package name in propagatedBuildInputs, otherwise a package definition with -pkg to signify it is packaged here and not in nixpkgs.

for updating, all that is needed is to change the version name, nix will recognise the hash is wrong and give the correct hash to put in, and then it should work fine. if you want this in the main repo, I can write something for that too.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again for tardiness, @christhepanda28 . I appreciate the notes and think that this is a great start, so will merge it. Appreciated!

@jzohrab jzohrab added this to Lute-v3 Jul 18, 2025
@jzohrab jzohrab moved this to In Progress in Lute-v3 Jul 18, 2025

@jzohrab jzohrab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jzohrab jzohrab merged commit fbf1167 into LuteOrg:master Aug 15, 2025
1 check passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Lute-v3 Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants