ci(fork): run Validate lime-elements on PRs targeting lime#7
Merged
Conversation
The workflow only triggered on PRs to main, but the fork's default branch is lime and all fork PRs target it, so the check never ran. Add lime to the base-branch filter while keeping main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
limeto the base-branch filter of theValidate lime-elementsworkflow trigger:Why
The workflow came over from upstream
jgroth/kompendiumand only triggered on PRs tomain. But this fork's default branch islime, and all fork PRs targetlime— so the check never ran (PR #6 shows only Block Autosquash / CI / Lint; the workflow has zero runs).For
pull_request, thebranchesfilter matches the PR's base branch, so addinglimeis what makes it fire on our PRs.mainis kept for any main-targeted PRs and to minimize divergence from upstream.Nothing else needed adapting: the workflow already checks out the public
Lundalogik/lime-elements@main, and the build/link steps are repo-agnostic.Self-test
This PR's base is
limeand its head contains the new trigger, so theValidate lime-elementscheck should run on this PR itself.Note
This is a fork customization on a file that
sync-upstream.ymlpulls from upstream, so future syncs may conflict on this line — expected and trivial to resolve.