Chime Device Type#577
Open
lboue wants to merge 15 commits into
Open
Conversation
…er-1.6.0.md) document
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ayChimeSound method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the Matter Chime device type / cluster, allowing plugins to expose devices (e.g. doorbells, alert devices) that can play a selected or requested chime sound.
MatterbridgeChimeServerbehavior (packages/core/src/behaviors/chimeServer.ts), extendingChimeServer, which handles theplayChimeSoundcommand: resolves the chime ID from the request or falls back toselectedChime, forwards the command to the Matterbridge command handler, logs the action, and emits thechimeStartedPlayingevent.MatterbridgeEndpoint.createDefaultChimeClusterServer(...)helper to create a default Chime cluster server with configurableinstalledChimeSounds,selectedChime, andenabledstate.chimedevice type inaddClusterServers()so it is created automatically viaaddRequiredClusterServers().MatterbridgeEndpointCommandHandlerwith theplayChimeSoundcommand handler type/entry (Chime.playChimeSound).MatterbridgeChimeServerfrompackages/core/src/behaviors/export.ts.createDefaultChimeClusterServerdefault-attributes test inmatterbridgeEndpoint-default.test.ts.playChimeSoundcommand invocation inmatterbridgeEndpoint-matterjs.test.ts.Test plan
npm run build(tsgo) passes with no type errors.npm run lintno longer reports thechimeServer.tswarning.playChimeSoundcommand flow (request with/withoutchimeId, log output,chimeStartedPlayingevent).