Fix Windows path sanitization in publication_output_dir_fields#55
Merged
LuisMRaimundo merged 1 commit intoJun 12, 2026
Conversation
On Linux, Path(r"C:\Users\bob\...") does not parse Windows backslash
paths correctly — the entire string becomes a single path component,
so .name returns the full path. Replace("\\", "/") then produced
"C:/Users/bob/..." which leaked the username into output_dir_relative.
Mirror the pattern already used in sanitize_path_for_publication and
publication_audio_path_fields: detect Windows-style paths and use
PureWindowsPath so .name correctly extracts only the last component.
AI-Generated: true
LuisMRaimundo
merged commit 604b9e6
into
improve-density-edge-contract-tests-2
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publication_output_dir_fieldsusedPath(str(path))on Linux, which does not treat backslashes as separators. A Windows path likeC:\Users\bob\Downloads\run\clip.wavwas kept as a single path component, so.namereturned the full string. The subsequentreplace("\\", "/")then producedC:/Users/bob/Downloads/run/clip.wav— leaking the username intooutput_dir_relative._WIN_ABS_START_EXPORTor containing\\) and usingPureWindowsPathfor them, consistent withsanitize_path_for_publicationandpublication_audio_path_fields.test_sanitized_export_tree_contains_no_windows_username_fragments(job 158).Test plan
tests/phase_12/test_metadata_sanitizer_contract_additional.py::test_sanitized_export_tree_contains_no_windows_username_fragmentsshould now passhttps://app.circleci.com/agents/gh/LuisMRaimundo/chat/2e09c802-6f76-4f0d-a416-8ac2d4525de1