Integrate finalize envs and authentication on repos - #2
Conversation
| func copyConfig(config, rootfsWanted string, fs vfs.FS, s *schema.SystemSpec) error { | ||
| // cfg, _ := fs.RawPath(s.Luet.Config) | ||
| repos, err := s.Luet.Repositories.Marshal() | ||
| repos, err := s.Luet.Marshal() |
There was a problem hiding this comment.
| repos, err := s.Luet.Marshal() | |
| luetCfg, err := s.Luet.Marshal() |
b46a830 to
251de26
Compare
|
I'm not sure about the name of the |
e0dfd2b to
6686456
Compare
|
Can we go ahead with this? |
|
|
||
| } else if len(s.Packages.Rootfs) > 0 { | ||
|
|
||
| if s.EnsureCommonDirs { |
There was a problem hiding this comment.
Disjoin this if and do this operation just once please
There was a problem hiding this comment.
sorry, but after two months it's a bit hard to follow the speech. Is not executed one time the method prepareRootfs?
What means do this operation just once?
There was a problem hiding this comment.
ah maybe, I understood. But you can do this only after unpack of the image and before luet install. The previous implementation was after luet install and this was wrong because the commons directories must be available before you begin to install the packages else the installation failed.
There was a problem hiding this comment.
Maybe the speech is: do you want to permit to define the list of the packages to install also with image? If yes we could move EnsureCommonsDir later and only one time. But before LuetInstall.
mudler
left a comment
mudler
left a comment
There was a problem hiding this comment.
just a minor nitpick but looks good
2 participants
Hereinafter the list of changes: