Skip to content

fix(slideshow): read globals from app_settings, not the missing setti…#318

Merged
Luca-Timo merged 1 commit into
betafrom
feat/live-slideshow
Jun 20, 2026
Merged

fix(slideshow): read globals from app_settings, not the missing setti…#318
Luca-Timo merged 1 commit into
betafrom
feat/live-slideshow

Conversation

@Luca-Timo

Copy link
Copy Markdown
Owner

…ngs table

slideshowSettings used settingsService.getSetting, which queries db('settings')

  • a table that does not exist in this app (globals live in app_settings). Every GET /gallery/:slug/show/:token/session and /state therefore threw and returned 500 INTERNAL_ERROR once a valid token resolved. Switch to getAppSetting (utils/appSettings), which reads app_settings where the slideshow_watermark_* and branding_* values are actually written.

Description

Please include a summary of the changes and which issue is fixed. Include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Unit tests pass (npm test)
  • Manual testing completed
  • Tested on Docker deployment
  • Tested on production-like environment

Test Configuration:

  • PicPeak Version:
  • Node.js Version:
  • Database: PostgreSQL / SQLite
  • Browser:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have updated the CHANGELOG.md file

Screenshots (if appropriate):

Additional Notes:

Add any additional notes, concerns, or discussion points here.

…ngs table

slideshowSettings used settingsService.getSetting, which queries db('settings')
- a table that does not exist in this app (globals live in app_settings). Every
GET /gallery/:slug/show/:token/session and /state therefore threw and returned
500 INTERNAL_ERROR once a valid token resolved. Switch to getAppSetting
(utils/appSettings), which reads app_settings where the slideshow_watermark_*
and branding_* values are actually written.
@Luca-Timo Luca-Timo merged commit 8e2f664 into beta Jun 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant