Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,14 @@
description: Prints equipment and circuitboards for use by engineering department.
components:
- type: Sprite
sprite: Structures/Machines/techfab.rsi
# LP Edit Start
sprite: _LP/Structures/Machines/engi_protolathe.rsi
snapCardinals: true
# LP Edit End
Comment on lines +28 to +31

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

В этом файле в нескольких местах остались временные комментарии, такие как # LP Edit Start/End и # LP Edit (здесь, а также на строках 47, 103-106, 122, 173-176, 192). Их следует удалить для чистоты кода.

    sprite: _LP/Structures/Machines/engi_protolathe.rsi
    snapCardinals: true

layers:
- state: icon
map: ["enum.LatheVisualLayers.IsRunning"]
- state: engi
# - state: engi LP Edit

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Закомментированные слои, такие как engi на этой строке (а также cargo на строке 110 и sci на строке 180), следует удалить, если они больше не нужны. Оставление закомментированного кода без объяснений затрудняет поддержку.

- state: unlit
shader: unshaded
map: ["enum.PowerDeviceVisualLayers.Powered"]
Expand All @@ -41,7 +44,7 @@
board: EngineeringTechFabCircuitboard
- type: Lathe
idleState: icon
runningState: icon
runningState: building # LP Edit

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Временный комментарий # LP Edit следует удалить. Подобные комментарии также присутствуют на строках 122 и 192.

    runningState: building

staticPacks:
- SharedBoardsStatic
- EngineeringBoardsStatic
Expand Down Expand Up @@ -97,11 +100,14 @@
description: Prints equipment and circuitboards for use by cargo department.
components:
- type: Sprite
sprite: Structures/Machines/techfab.rsi
# LP Edit Start
sprite: _LP/Structures/Machines/cargo_protolathe.rsi
snapCardinals: true
# LP Edit End
layers:
- state: icon
map: ["enum.LatheVisualLayers.IsRunning"]
- state: cargo
# - state: cargo LP Edit
- state: unlit
shader: unshaded
map: ["enum.PowerDeviceVisualLayers.Powered"]
Expand All @@ -113,7 +119,7 @@
board: CargoTechFabCircuitboard
- type: Lathe
idleState: icon
runningState: icon
runningState: building # LP Edit
staticPacks:
- ToolsStatic
- SharedBoardsStatic
Expand Down Expand Up @@ -164,11 +170,14 @@
description: Prints equipment and circuitboards for use by science department.
components:
- type: Sprite
sprite: Structures/Machines/techfab.rsi
# LP Edit Start
sprite: _LP/Structures/Machines/rnd_protolathe.rsi
snapCardinals: true
# LP Edit End
layers:
- state: icon
map: ["enum.LatheVisualLayers.IsRunning"]
- state: sci
# - state: sci LP Edit
- state: unlit
shader: unshaded
map: ["enum.PowerDeviceVisualLayers.Powered"]
Expand All @@ -180,7 +189,7 @@
board: ScienceTechFabCircuitboard
- type: Lathe
idleState: icon
runningState: icon
runningState: building # LP Edit
staticPacks:
- SharedBoardsStatic
- EngineeringBoardsStatic
Expand Down
58 changes: 58 additions & 0 deletions Resources/Prototypes/_LP/Entities/Structures/Machines/lathe.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
- type: entity
id: LPPServiceProtolathe
parent: [BaseLatheLube, BaseSiloUtilizer]
name: engineering techfab
description: Prints equipment and circuitboards for use by engineering department.
Comment on lines +4 to +5

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Название (name) и описание (description) этого прототипа, похоже, скопированы из EngineeringTechFab. Однако id (LPPServiceProtolathe) и спрайт (serv_protolathe.rsi) указывают на то, что это сервисный протолазер. Для ясности и консистентности стоит обновить name и description, чтобы они соответствовали назначению объекта.

  name: service protolathe
  description: Prints equipment and circuitboards for use by the service department.

components:
- type: Sprite
sprite: _LP/Structures/Machines/serv_protolathe.rsi
snapCardinals: true
layers:
- state: icon
map: ["enum.LatheVisualLayers.IsRunning"]
- state: unlit
shader: unshaded
map: ["enum.PowerDeviceVisualLayers.Powered"]
- state: panel
map: ["enum.WiresVisualLayers.MaintenancePanel"]
- type: Machine
board: EngineeringTechFabCircuitboard
- type: Lathe
idleState: icon
runningState: building
staticPacks:
- SharedBoardsStatic
- CircuitFloorsStatic
- ToolsStatic
- PartsStatic
- AtmosStatic
- CablesStatic
- MaterialsStatic
- LightsStatic
- PowerCellsStatic
- ElectronicsStatic
- MiscSignallersStatic
- NailgunStatic
- NailsStatic
dynamicPacks:
- ServiceTools
- AtmosTools
- PowerCells
- Equipment
- SpecOpsGoogles
- EngineeringBoards
- SharedBoards
- CameraBoards
- UpgradeKits
# CorvaxGoob Packs
- WorkBeltsSharedDynamic # WorkBelts-Techfab
- WokrBeltsEngDynamic # WorkBelts-Techfab

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Здесь опечатка в названии пакета: WokrBeltsEngDynamic. Вероятно, должно быть WorkBeltsEngDynamic.

    - WorkBeltsEngDynamic # WorkBelts-Techfab

- type: EmagLatheRecipes
emagStaticPacks:
- NailgunEvilStatic
- type: MaterialStorage
whitelist:
tags:
- Sheet
- RawMaterial
- Ingot

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Файл заканчивается без перевода строки. Рекомендуется добавлять пустую строку в конец файла для соответствия стандартам и лучшей совместимости с инструментами разработки.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "Made by BL02DL",
"size": {
"x": 32,
"y": 32
},
"states": [
{
"name": "icon"
},
{
"name": "panel"
},
{
"name": "unlit"
},
{
"name": "building",
"delays": [
[
0.09,
0.09,
0.09,
0.09,
0.09,
0.09,
0.09,
0.09,
0.09,
0.09,
0.09,
0.09,
0.09
]
]
},
{
"name": "inserting",
"delays": [
[
0.1,
0.1,
0.1,
0.1,
0.1,
0.1,
0.1,
0.1
]
]
}
]
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24",
"size": {
"x": 32,
"y": 32
},
"states": [
{
"name": "icon"
},
{
"name": "panel"
},
{
"name": "unlit"
},
{
"name": "building",
"delays": [
[
0.5,
0.5,
0.5,
0.5,
0.5,
0.5,
0.5,
0.5,
0.5,
0.5,
0.5,
0.5,
0.5
]
]
},
{
"name": "unlit-building",
"delays": [
[
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10
]
]
},
{
"name": "inserting",
"delays": [
[
0.1,
0.1,
0.1,
0.1,
0.1,
0.1,
0.1,
0.1
]
]
}
]
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "BL02DL",
"size": {
"x": 32,
"y": 32
},
"states": [
{
"name": "icon"
},
{
"name": "panel"
},
{
"name": "unlit"
},
{
"name": "building",
"delays": [
[
0.8,
0.8,
0.8,
0.8,
0.8,
0.8,
0.8,
0.8,
0.8,
0.8,
0.8,
0.8,
0.8
]
]
},
{
"name": "unlit-building",
"delays": [
[
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10,
0.10
]
]
},
{
"name": "inserting",
"delays": [
[
0.1,
0.1,
0.1,
0.1,
0.1,
0.1,
0.1,
0.1
]
]
}
]
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading