Fix mistake in _Undone.txt, add new INT 15 AX=EC00

[michael-sermir]

My request got merged before I got a chance to fix this mistake, extremely sorry for the extra PR! This is probably necessary for readability, though.

[michael-sermir]

I would appreciate a quick look at my new interrupt file if anyone has the chance--I'm not sure I got the formatting right, especially the UID.

[ecm-pushbx]

Please split last commit into two: Only renaming the directory, then adding your new file. Force push to change this PR. Reviewing it like this is very cumbersome.

[shidel]

As @ecm-pushbx mentioned, this would be better in a separate push. :-)

One issue, with the new file. No RBIL entry has more than one Category. I do understand why you would like to do that. Maybe, we will want to change that. Maybe not. If we do, then it sould only be one entry per line like with Flag:.

The main problem is (at this time) only one category is supported. If we wish to support multiple there would need to be a couple of changes.

First, makelist is not going to like more than one character there. It will also not like Multiple category entries. But, that is an easy fix.

Second, the RBIL section entries in the created LST files only has one character position available for a Category. It would be possible to extend this to two characters for modern parsers. But not three without major structure changes to the section headers. However, even two categories could break compatibility with older parsers. So, an additional routine would need added to the --legacy mode of makelist to only provide the first Category.

Perhaps it would be better to add something in Flags regarding some things like Vendor Specific. Flags are mostly empty.

[michael-sermir]

@ecm-pushbx I'm very sorry, but I've never done that before using Git. How would I change an already-made commit?

[ecm-pushbx]

@ecm-pushbx I'm very sorry, but I've never done that before using Git. How would I change an already-made commit?

Not sure to be honest. Maybe use git log to find the hash of the last commit to keep. Store your new file in a temporary space. Then git checkout THATHASH. Then create the first new commit (re-do the rename and git commit -am "MESSAGE") and then the second (copy temporary file to destination, git add THATFILE then commit like normal). You want to push to the same branch/head that this PR tracks. May need --force on git push to replace the current commits.

It seems you used main head for the PR, I don't have experiences with that. You could also git checkout -b YOURBRANCHNAME and then create a new PR.

@shidel Any pointers on how to do this?

[michael-sermir]

Fixed it! All good now hopefully. @shidel Also fixed that point about the Category, just gave it "vendor-specific BIOS extension". :)

[ecm-pushbx]

Please change INT 15 CASSETTE to INT 15 SYSTEM FUNCTIONS, that is don't drop the INT 15. You should be able to force push in the same way.

[ecm-pushbx]

I don't see how the flag "C" for Callout applies to 15.EC00. The category "b" should be spelled out in the file, for example

TheList/source/Interrupt List/INT 15 CASSETTE/INT 15E881 Phoenix BIOS v40 GET MEMORY SIZE FOR 64M CONFIGURATIONS 32bit.txt

Line 3 in aacd000

Category: b vendor-specific BIOS extensions

(Just open this file locally and copy the line to exactly match the whitespace.)

[michael-sermir]

@ecm-pushbx:

I don't see how the flag "C" for Callout applies to 15.EC00.

In the manual, it's listed as a "callback". The "C" flag was called "callback or callout" so I figured it applied. Is this incorrect?

[ecm-pushbx]

I don't think it fits the meaning of C, as seen here:

TheList/source/Interrupt List/_Flags.txt

Line 13 in aacd000

C - callout or callback (usually hooked rather than called)

Note the "usually hooked rather than called", indicating there's more users that hook and a few or single user calling it. I don't think that seems applicable.

[ecm-pushbx]

Laat commit appears to be empty.

[michael-sermir]

Note the "usually hooked rather than called", indicating there's more users that hook and a few or single user calling it. I don't think that seems applicable.

Makes sense! I will fix that.

I tried to fix the incorrect commit message (I did rename the directory to INT 15 SYSTEM FUNCTIONS, just forgot the INT 15 in the commit message) via what the Git manual called a "reword" commit, but it seems like it didn't do a whole lot. I can try to roll it back and re-apply the commit with the tweaked wording if you think it would be necessary.

[ecm-pushbx]

Ah, yes, you did use the INT 15 prefix for the actual filenames, I missed that. Yes, I'd rather you force push again to fix everything. You don't have to keep your latest commit "Fixed Category/Flags as suggested by ecm-pushbx" separately, just do a single commit that adds the updated file immediately. At least that's what I'd prefer.

[michael-sermir]

Should be fixed now, but if I need to correct anything further I certainly will.

[ecm-pushbx]

Looks all good to me! Thank you.

[michael-sermir]

Thank you for taking so much time to validate it! :)

[shidel]

It seems you used main head for the PR, I don't have experiences with that. You could also git checkout -b YOURBRANCHNAME and then create a new PR.

@shidel Any pointers on how to do this?

@ecm-pushbx, Sorry, I cannot help with that either. While git is very powerful and can do a lot, it can often be a royal pain to figure out how to get it to do exactly what you want. There are often times when I just say the heck with it, nuke my local copy, re-clone a project, apply any new changes and re-push.