Second attempt at hiding unapproved projects on profile pages - #2639
Merged
Conversation
Hopefully shouldn't show the project to everyone after someone joins Closes: #2405
mel8978
changed the title
NadaIsAvailable
requested changes
Aug 6, 2026
Collaborator
Author
|
Alright back to the grind |
Collaborator
Author
|
Alright should be fixed |
NadaIsAvailable
approved these changes
Aug 7, 2026
NadaIsAvailable
left a comment
NadaIsAvailable
left a comment
Collaborator
There was a problem hiding this comment.
was passing the wrong user id (the current display user profile's user id) so no matter who was viewing, they could see all projects.
also const isOwnProfile = userID > 0 && data.userId === userID; was always false, although it looks correct. so instead of checking again, just use the result to set IsUsersProfile from above.
Collaborator
Author
|
Thanks for the feedback, hopefully this time I'll finally finish it properly 😭 |
Collaborator
u r fine now, i pushed the changes when i was debugging it ;) |
Collaborator
Author
|
oh ok thanks a bunch |
HoliestGamer
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully shouldn't show the project to everyone after someone joins Closes: #2405