fix: restore Linux and macOS CI builds#8
Draft
LoogLong wants to merge 4 commits into
Draft
Conversation
- Include <cstdint> in Jolt Core.h so uint8_t/uint32_t are available on newer Clang/libc++ combinations used by GitHub Actions runners. - Raise tinyobjloader CMake minimum to 3.5 for compatibility with CMake 4. - Install documented Linux build dependencies (clang, libc++-dev, libxrender-dev). - Pass CMAKE_POLICY_VERSION_MINIMUM in build_macos.sh for legacy CMake projects. - Update GitHub Actions checkout action to v4. Co-authored-by: wenlong li <LoogLong@users.noreply.github.com>
- Include <algorithm> in reflection.cpp for std::find_if. - Suppress -Wnontrivial-memcall for Jolt on Clang (Xcode 26+). Co-authored-by: wenlong li <LoogLong@users.noreply.github.com>
- Remove stray leading spaces in build_macos.sh Xcode config names. - Patch sol2 optional<T&>::emplace for newer libc++/Clang (Xcode 26+). Co-authored-by: wenlong li <LoogLong@users.noreply.github.com>
Co-authored-by: wenlong li <LoogLong@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes failing GitHub Actions builds on Linux and macOS after recent runner/toolchain updates (Clang 19+, CMake 4.x, Xcode 26).
Root causes
Core.hmissing<cstdint>;reflection.cppmissing<algorithm>; VMAsnprintfwithout<cstdio>tinyobjloaderCMake 3.2 unsupported;build_macos.shused" Debug"/" Release"(leading space → wrong Xcode config); sol2optional<T&>::emplaceincompatible with newer libc++; Jolt-Wnontrivial-memcallChanges
cstdint,algorithm,cstdio)tinyobjloaderCMake minimum to 3.5build_macos.shXcode configuration namesoptional<T&>::emplace(Conan upstream patch)-Wnontrivial-memcallfor Jolt on ClangVerification
All 6 CI jobs pass on this PR (Linux/macOS/Windows × debug/release).