feat: enhanced grade label#1139
Conversation
|
Hi, I think this could clutter the UI quite a bit. At least for outdoor scenarios the mean user grade differing from the author grade is really rare. This means, that we would basically see two times the same grade everywhere. Wouldn't it be enough to see this info on the line detail page? |
|
Yes, could also work. Although I do actually see grade difference quite often for outdoor problems as well. Example from Fontainebleau: But in the line detail page can also work. I’ll update the PR next week. |
|
Sure, up- and downgrades happen regularly. My point was only that the actual mean user grade being a different one than the topo author grade doesn't happen very often. |
|
no it was published as 7A but the consensus is 7A/6C+ there. So it's probably not the mean but the avg (which ends up around 6C/6C+). |
senn
force-pushed
the
feat/enhanced-grade-label
branch
from
9d30948 to
7cb3bda
Compare
|
looks like this now: this is a super basic way of showing it. Let me know if you want it differently. |
| if candidate1 <= mean_grade: | ||
| candidate2 = all_grades[ | ||
| lower_grade_index + 1 if lower_grade_index + 1 < len(all_grades) else len(all_grades) | ||
| lower_grade_index + 1 if lower_grade_index + 1 < len(all_grades) else len(all_grades) - 1 |
There was a problem hiding this comment.
I accidentally found a bug while testing user grades. When selecting the highest possible grade this gave an IndexError.
I do wonder if this needs a migration for existing deployments?
There was a problem hiding this comment.
i also added a test for this
2 participants
Just a small idea I had after some users told me they would like to be able to compare the original grade to the user grade.
Depending on the shown-grade toggle, it shows the other grade between brackets (in some places) with a related icon. The logic of the toggle stays the same, it's purely visual so no migration necessary.
Toggle = author grade, so user grade between brackets
Toggle = user grade, so author grade between brackets
I have not created an issue for this, but if needed I can create one retroactively...