Skip to content

Feature: Alter highlighting to allow you to have a smooth polygon around the sail#88

Closed
ARTARNA wants to merge 3 commits into
LlemonDuck:mainfrom
ARTARNA:trimmable-config
Closed

Feature: Alter highlighting to allow you to have a smooth polygon around the sail#88
ARTARNA wants to merge 3 commits into
LlemonDuck:mainfrom
ARTARNA:trimmable-config

Conversation

@ARTARNA

@ARTARNA ARTARNA commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

This PR tweaks the sails highlight overlay.

Currently the overlay always draws the large “area” outline around the whole ship

Changes in this PR:

  • Add a config option Rigging highlight mode with two options:
    • Area – current behaviour, highlight the full sailing area.
    • Sail – only highlight the sail polygon (what was requested in the issue).

Closes #76

@Louiziana

Copy link
Copy Markdown

Was the feature able to be cleanly implemented?

@ARTARNA

ARTARNA commented Nov 25, 2025

Copy link
Copy Markdown
Contributor Author

Was the feature able to be cleanly implemented?

I am happy with my implementation but llemon may not. You can test it from this snapshot if you know how to, otherwise wait for it to be included in sailing (if llemon wants it)

@LlemonDuck

Copy link
Copy Markdown
Owner

@Louiziana Approving these changes as a non-maintainer is not helpful

@ARTARNA can you rebase off the merged #46

@ARTARNA

ARTARNA commented Nov 28, 2025

Copy link
Copy Markdown
Contributor Author

@LlemonDuck updated :)

@Louiziana

Copy link
Copy Markdown

@LlemonDuck got it, sorry! :'(

@ARTARNA

ARTARNA commented Dec 12, 2025

Copy link
Copy Markdown
Contributor Author

@LlemonDuck finally got around to fixing this with the latest :)

@LlemonDuck

Copy link
Copy Markdown
Owner

thanks, done in 3bb6395. only thing changed was reordering config to move it beside the corresponding checkbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion: Highlight Sails option to make it Outline instead of Hull

3 participants