Skip to content

refactor(sonar): fix javascript:S5906 #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Jun 23, 2026
Merged

refactor(sonar): fix javascript:S5906 #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<div align="center">
<a href="https://github.com/LizardByte/i18n/actions/workflows/_ci-node.yml?query=branch%3Amaster"><img src="https://img.shields.io/github/actions/workflow/status/lizardbyte/i18n/_ci-node.yml.svg?branch=master&label=CI%20build&logo=github&style=for-the-badge" alt="GitHub Workflow Status (CI)"></a>
<a href="https://codecov.io/gh/LizardByte/i18n"><img src="https://img.shields.io/codecov/c/gh/LizardByte/i18n?token=98qpC83uM0&style=for-the-badge&logo=codecov&label=codecov" alt="Codecov"></a>
<a href="https://sonarcloud.io/project/overview?id=LizardByte_i18n"><img src="https://img.shields.io/sonar/quality_gate/LizardByte_i18n?server=https%3A%2F%2Fsonarcloud.io&style=for-the-badge&logo=sonar&label=sonarcloud" alt="SonarCloud"></a>
<a href="https://sonarcloud.io/project/overview?id=LizardByte_i18n"><img src="https://img.shields.io/sonar/quality_gate/LizardByte_i18n?server=https%3A%2F%2Fsonarcloud.io&style=for-the-badge&logo=sonarqubecloud&label=sonarcloud" alt="SonarCloud"></a>
</div>

<div align="center">
Expand Down
2 changes: 1 addition & 1 deletion tests/crowdin-progress.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ describe('buildProjectTable', () => {
it('produces an empty table body when entries array is empty', () => {
const table = buildProjectTable(makeProject(), []);
const lines = table.split('\n');
expect(lines.length).toBe(2);
expect(lines).toHaveLength(2);
});

it('handles an entry with null language gracefully', () => {
Expand Down
2 changes: 1 addition & 1 deletion tests/sync-crowdin-issues.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ describe('buildIssueTitle', () => {

it('truncates long text to 72 characters', () => {
const issue = { text: 'a'.repeat(100) };
expect(buildIssueTitle(issue).length).toBe(72);
expect(buildIssueTitle(issue)).toHaveLength(72);
});

it('collapses newlines to spaces', () => {
Expand Down