Add a file name filter to the torrent file selection screen#473
Merged
LivingWithHippos merged 4 commits intoJul 11, 2026
Merged
Conversation
Adds a filter bar to the file picker shown while adding a torrent. Plain text matches any part of a file name, and * wildcards are supported to match by extension, e.g. *.mkv. A new checkbox selects or deselects all the currently visible files, so *.mkv + checkbox selects all the mkv files in one go. Closes LivingWithHippos#450 Closes LivingWithHippos#462
The selection DiffCallback already compares TorrentFileItem.selected, so submitList alone rebinds the rows whose checkbox state changed. The extra notifyDataSetChanged forced every row to fully rebind on top of that, discarding the diffing work.
LivingWithHippos
approved these changes
Jul 11, 2026
also check binding
LivingWithHippos
merged commit d24a635
into
LivingWithHippos:master
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a filter field to the file picker shown while adding a torrent. Plain text matches any part of a file name, and * is supported for patterns like *.mkv. Next to it there is a checkbox that selects or deselects all the files currently shown, so *.mkv plus the checkbox selects every mkv file in one go, like suggested in #450.
With an empty filter the folder structure is shown as before. While a filter is active the matching files are shown as a flat list and the folder rows are hidden, since selecting a folder would also pick files that are filtered out.
Closes #450
Closes #462