[codex] Normalize linx-model fixture naming across docs and codec tooling#2
Conversation
The superproject now refers to the LLVM ELF minst fixture path consistently, so the model repo needs its docs, generator wording, and emitted record labels to match. This keeps the lightweight model references aligned with the rest of the bring-up documentation and tooling. Constraint: Superproject bring-up docs now use the LLVM ELF fixture naming consistently Rejected: Keep the legacy names in model docs and codec code | leaves the model surface inconsistent with the active bring-up docs Confidence: medium Scope-risk: narrow Directive: Keep minst fixture names synchronized between documentation and generator output Not-tested: No dedicated linx-model build or regression rerun in this publish turn
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the LinxISA version from v0.4 to v0.56 across the build system, documentation, and source code. Feedback was provided regarding hardcoded absolute paths in the documentation and the codec generation script, which hinder portability; specifically, it was suggested to make the --spec argument required in the script rather than relying on a user-specific default path.
| parser.add_argument( | ||
| "--spec", | ||
| default="/Users/zhoubot/linx-isa/isa/v0.4/linxisa-v0.4.json", | ||
| default="/Users/zhoubot/linx-isa/isa/v0.56/linxisa-v0.56.json", |
There was a problem hiding this comment.
The default value for the --spec argument is a hardcoded absolute path to a specific user's home directory. This makes the script non-portable. Since the build system (CMakeLists.txt) already provides this path explicitly, it is better to remove the default and make the argument required to avoid accidental use of an invalid path.
| default="/Users/zhoubot/linx-isa/isa/v0.56/linxisa-v0.56.json", | |
| required=True, |
| The source of truth is: | ||
|
|
||
| - `/Users/zhoubot/linx-isa/isa/v0.4/linxisa-v0.4.json` | ||
| - `/Users/zhoubot/linx-isa/isa/v0.56/linxisa-v0.56.json` |
There was a problem hiding this comment.
The path to the ISA specification is hardcoded as an absolute path to a specific user's home directory (/Users/zhoubot/...). This should be updated to a relative path or a generic placeholder to ensure it is accurate for all developers and environments.
1 participant
What changed
Why
The superproject documentation now refers to the fixture path consistently, and the model repo needs to match that surface.
Impact
This keeps the lightweight model/docs lane consistent with the rest of the bring-up documentation stack.
Validation