Make some UI changes#5
Open
LinnierGames wants to merge 5 commits into
Open
Conversation
c363118 to
0c3595a
Compare
d9d55b7 to
470aa35
Compare
LinnierGames
commented
Sep 7, 2020
|
|
||
| class WeatherViewModel { | ||
| private(set) var validAddresses = [Address]() | ||
| private(set) var invalidAddresses = [Address]() |
Owner
Author
There was a problem hiding this comment.
woodward4422 2 days ago @woodward4422
Why are these two seperate arrays? Why do we need to store invalid adresses in a variable?
LinnierGames 1 hour ago Author Owner
IIUC, having two variables reads better than a 2-dimensional array named something like var addresses: [Address] where addresses[0] contains the list of valid addresses and addresses[1] contains the list of invalid addresses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I changed or removed
What I added
What I would have loved to change/add if I put more time