fix(review): avoid repeat PR findings#6
Conversation
Mimir review — 🟡 CommentsWell-structured PR that adds fingerprint-based duplicate inline comment suppression across review cycles. The core logic is clean, error-handling is thorough (graceful degradation when discussion fetch fails), and tests cover the key paths including legacy unmarked comments. Two minor issues worth fixing: the pagination fallback can silently miss comments on very large PRs, and human reply text in the LLM prompt creates a prompt-injection surface that could be better mitigated. Two nits for transparency and testability. Findings: 0 critical · 0 major · 2 minor · 2 nit (suppressed) General findings
💰 Review cost: $0.0104 — primary |
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to suppress duplicate inline comments by fetching, parsing, and tracking existing PR review discussions. It adds fingerprinting logic for findings, integrates this context into the review workflow, and includes comprehensive tests. The review feedback highlights opportunities to improve robustness and efficiency, specifically by using a lazy regex match to handle titles with asterisks, wrapping decodeURIComponent in a try-catch block to prevent potential URIError crashes, and refactoring redundant map lookups in the discussion parser.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
Tests