DONKEY-561 Make the sandbox tree collapse button tabbable#34
Closed
kailin-limble wants to merge 4 commits into
Closed
DONKEY-561 Make the sandbox tree collapse button tabbable#34kailin-limble wants to merge 4 commits into
kailin-limble wants to merge 4 commits into
Conversation
to conform to accessibility standards
slcwebguy
reviewed
Dec 6, 2024
Contributor
|
question: did you check these updates across browsers by chance? What you have looks like it should work. I'm just wondering if maybe there are some different browser-specific implementations of |
slcwebguy
approved these changes
Dec 13, 2024
Author
standard on all browsers except IE11 |
- add type, aria-expanded, and aria-label attributes - mark icons as aria-hidden - improve focus-visible styling with solid outline and offset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to conform to accessibility standards
https://limble.atlassian.net/browse/DONKEY-561