Conversation
…ION=22 Set MIN_ACCEPTED_SIM_VERSION = SIM_VERSION_V22_DIFFICULTY = 22 (= LATEST). Saves older than V22 throw OldSimVersionError and are deleted on boot; saves newer than V22 still throw FutureSimVersionError and are preserved. - Remove all version-gated code paths in sim (V3/V5/V6/V8/V9/V10/V13/V15/V17/V21 guards) - Remove legacy migration helpers in save.ts (migrateBehaviorRatio, migrateInputLogCommand) - Make all SerializedWorldState fields required (drop optional `?`) - Remove V15 resolveCombatOnTile_v15 export; keep V16+ coin-flip path - Delete issue-42 / issue-44 snapshot-replay tests (fixtures pre-date MIN_ACCEPTED) - Delete / update all tests pinned to legacy simVersion values Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1140791433
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A pre-V22 save that has a valid envelope would pass hasSave() and show the Continue prompt, then silently delete the save and boot fresh with default difficulty when OldSimVersionError fires in bootFromSave. Gate the prompt on hasSave() && !hasIncompatibleSave() so only truly loadable saves show the Continue option; incompatible saves are bypassed and overwritten by the first autosave of the new game. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MIN_ACCEPTED_SIM_VERSION = SIM_VERSION_V22_DIFFICULTY = 22(=LATEST_SIM_VERSION). Saves older than V22 now throwOldSimVersionErrorand are deleted on boot; saves newer than V22 still throwFutureSimVersionErrorand are preserved.migrateBehaviorRatioandmigrateInputLogCommandfromsave.ts.SerializedWorldStatefields required (dropped optional?).resolveCombatOnTile_v15export; V16+ coin-flip path is always used.issue-42andissue-44snapshot-replay test files (fixtures were pre-V22).simVersionvalues.Test plan
npx vitest run)npx tsc --noEmit)🤖 Generated with Claude Code