Fix : 修复洛茜战技在时间轴上时,撤销和重做无法正常执行的问题#43
Open
SQwatermark wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
为洛茜天赋斫痕注入到战技中的 razorClawmark DoT 效果添加 id,避免技能数据在恢复历史快照后重新生成随机 id 导致该快照重新被写入历史记录
补充:
对所有干员的类似技能进行排查,发现以下干员技能仍有相同问题。感觉生成随机ID的逻辑很怪,可能需要看看这块是不是需要重构,而不是单纯补一个ID
patchHit.hit.effects 注入效果
→ patchCombatSkills()
→ resolveEffect(e, idx)
→ effect.id ?? uid()
→ 恢复历史后重新生成随机 id
→ displayType/序列化结果变化
→ 撤销历史被污染
patchHit 注入 effect 缺 id
avywenna-ultimate-hitstatuscatcher-ultimate-last-hitdamageHitxaihi-combo-hitstatusember-ultimate-hitstatusfluorite-battle-explosive-expire-damage-hitstatusfluorite-battle-explosive-consumed-damage-hitstatuswulfgard-battle-additional-shotderivedwulfgard-battle-additional-shotderivedyvonne-ultimatestatusyvonne-ultimatestatus