ci(preview): stop waiting for Pages deployment after preview push#444
Merged
Conversation
The pr-preview-action was pushing all files successfully to LibreSign/site-preview but then blocking for 180s waiting for a GitHub Pages build in that repository to start, which timed out every run. The deploy already completed; there is no need to block the workflow waiting for the Pages CDN to propagate. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Contributor
|
Contributor
|
🚀 Starting production deploy of header and footer fragments... |
Contributor
|
🚀 Starting production deploy of site header and footer fragments... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every
Deploy PR previewsrun was failing with:The
rossjrw/pr-preview-actionwithwait-for-pages-deployment: truepushes all files toLibreSign/site-preview(confirmed: 21 439 files, 100%) and then polls for a GitHub Pages deployment in that repository. The build never starts within the 180s window, causing every preview deploy to time out.Fix
Set
wait-for-pages-deployment: false.The files are already on the
site-previewbranch. GitHub Pages will build asynchronously — the workflow does not need to block waiting for that. The preview URL becomes available once Pages propagates, which it does without us holding the runner.Change