Support for transparent textures without _fbr naming suffix#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces special support for textures with transparent texels (textures with a name starting with "{").
The color index for transparent texels is index 255 in the Quake palette, which is in the range of fullbright colors. Thus, currently, transparent textures need a "_fbr" suffix to enable this part of the palette. However, this can lead to transparent textures having unintended fullbright texels, as there are duplicate color entries in the fullbright and non-fullbright parts of the color palette.
With these changes, textures with the "{" prefix will have color index 255 available automatically, without enabling the rest of the fullbright palette.