mv: fix memleak when safe_create_leading_directories alloc failed - #6
Open
GermanAizek wants to merge 2 commits into
Open
mv: fix memleak when safe_create_leading_directories alloc failed#6GermanAizek wants to merge 2 commits into
GermanAizek wants to merge 2 commits into
Conversation
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
`dst_dup` variable, allocated with `xstrdup()`, is not always freed. If safe_create_leading_directories() fails, the allocated memory is leaked. Git codebase shows that it is recommended to always check result safe_create_leading_directories() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@metux,
dst_dupvariable, allocated withxstrdup(), is not always freed. If safe_create_leading_directories() fails, the allocated memory is leaked. Git codebase shows that it is recommended to always check result safe_create_leading_directories() function.