Skip to content

Fix uncaught exception with anonymous submodules #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fantazio merged 2 commits into from
May 28, 2026
Merged

Fix uncaught exception with anonymous submodules #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef0ab5e
[test][dune] Add test with an ignored/anonymous sub-module
david-maison-TrustInSoft May 26, 2026
ec4dc63
[src][deadCode] Fix uncaught exception with ignored/anonymous sub-mod…
david-maison-TrustInSoft May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/using_dune/lib/values/values_in_submodules.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ module Exported = struct

end

module _ = struct
let unused_int = 42
end

let () = ignore Unexported.used_int

let () = ignore Exported.Private.used_int
Expand Down
2 changes: 1 addition & 1 deletion src/deadCode.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ let structure_item super self i =
end;
let r = super.Tast_mapper.structure_item self i in
begin match i.str_desc with
| Tstr_module _ -> mods := List.tl !mods
| Tstr_module {mb_name = {txt = Some _; _}; _} -> mods := List.tl !mods
| _ -> ()
end;
r
Expand Down
Loading