Quick options - #23
Open
atuannguyen1101 wants to merge 6 commits into
Open
Conversation
atuannguyen1101
force-pushed
the
quickOptions
branch
4 times, most recently
from
May 5, 2018 18:22
1dd9747 to
fecb0e7
Compare
atuannguyen1101
force-pushed
the
quickOptions
branch
2 times, most recently
from
May 6, 2018 19:30
8526d9f to
19d8246
Compare
atuannguyen1101
force-pushed
the
quickOptions
branch
from
May 6, 2018 19:38
19d8246 to
842d32e
Compare
baonguyen2604
requested changes
May 7, 2018
baonguyen2604
left a comment
baonguyen2604
left a comment
Contributor
There was a problem hiding this comment.
có mấy chỗ tự nhiên set timeout r` mới call cái function là sao =)) chi v
vs mấy cái try catch nữa sao ko xài loop bthg
|
|
||
| // Set up all previous Reminders | ||
| updateDB.setAllReminders(); | ||
|
|
Contributor
There was a problem hiding this comment.
để ở ngoài th đừng để vô listen
| } | ||
| }) | ||
|
|
||
| // Act as loop's break |
Contributor
There was a problem hiding this comment.
sao ko xài loop break bthg
Contributor
Author
There was a problem hiding this comment.
Xài forEach không hỗ trợ break
| "text" : `Cannot find the Team: ${key}` | ||
| } | ||
| sendResponse.directMessage(sender_psid, response); | ||
| setTimeout(() => { |
Contributor
There was a problem hiding this comment.
mấy cái function này set timeout chi
Contributor
Author
There was a problem hiding this comment.
Cho nó delay 1 tí thay vì send 2 tin liên tục, dễ bị tin này đè tin kia
atuannguyen1101
force-pushed
the
quickOptions
branch
from
May 8, 2018 19:32
50de32c to
2f46001
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Reminder, Improve teams and players option.