Enhance scripts, linting, and documentation for consistency - #18
Merged
Conversation
hooks/copilot-hooks.json uses its own schema and its own PLUGIN_ROOT variable, so it could drift from hooks/hooks.json without any check failing. Assert that both sessionStart and subagentStart still expose PLUGIN_ROOT in the bash and powershell commands and still invoke hooks/semver-context.js. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QBQmSepsVmQJxefoL4hDb7
The four docs/README.*.md translations had to be kept in sync by hand, and two sections had already gone missing from all of them. Compare the structural skeleton — heading levels, fenced code blocks and images, ignoring content inside fences — which survives translation and is what actually drifts. Run it in CI alongside the version check. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QBQmSepsVmQJxefoL4hDb7
install-local.sh carries the most intricate logic in the repository — tar snapshot, marketplace rename, cachebuster build metadata, the Codex plugins symlink — with no automated coverage at all. Stub the harness CLIs on PATH and run with --dry-run so no harness is touched, then assert on the snapshot that prepare_snapshot actually builds. The base version under the build metadata is checked rather than the full version, since the cachebuster deliberately breaks version sync inside the snapshot. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QBQmSepsVmQJxefoL4hDb7
Markdown is the product here and there was no linter of any kind, only git diff --check for whitespace. Configure markdownlint-cli2 and shellcheck so the repository passes as-is: MD013 is off because badge rows and long links legitimately exceed the 80-column prose convention, MD024 and MD051 are relaxed for the per-harness repeated headings and the emoji anchors, and SC1007 is off because `CDPATH= cd --` is intentional. Add the lint, test and validate-translations targets, keep lint out of make validate so validation stays offline, and run all of it in CI. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QBQmSepsVmQJxefoL4hDb7
The bundled skills tell agents to follow "the project's documented 0.x policy", but this project never documented its own. State it: a breaking change to a published contract increments MINOR, everything else increments PATCH, and every merge into main carries a bump. The translations were also missing two whole sections that exist in the canonical README — Languages and Local source development — plus the make remove-local block under Uninstalling. Propagate all three to es, hi, pt-BR and zh-CN and update their tables of contents. Correct a factual error carried by all five files: the automation section listed three manifests that must share the version, omitting Gemini CLI. There are four. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QBQmSepsVmQJxefoL4hDb7
Give coding agents the context this repository's layout does not make obvious: AGENTS.md as the single source of the rule text, the five files whose versions must match, the POSIX-sh-only constraint on hook commands, and the branch and commit conventions. Add a PostToolUse hook that runs check-version.js when a version-bearing file is edited, so drift surfaces immediately instead of in CI, plus bump-version and sync-readmes skills for the two workflows that were previously manual and error-prone. settings.local.json is per-developer and stays untracked; settings.json is shared. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QBQmSepsVmQJxefoL4hDb7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.