Fix reject backup restore#120
Merged
Merged
Conversation
The Backup/Restore approval used nbgl_useCaseConfirm, whose callback only fires on "Approve". Pressing "Refuse" silently dismissed the modal without sending any APDU response, so the host waited forever (the WebUI stayed stuck with greyed-out buttons). Switch to nbgl_useCaseChoice, which reports both outcomes: approve keeps the previous behaviour, refuse answers SWO_CONDITIONS_NOT_SATISFIED (0x6985) and returns to the home page.
Cover the refusal path: triggering a Backup/Restore and pressing "Refuse" on the device must answer 0x6985 (ActionCancelledError). Adds an APDU_REJECT navigation instruction for both the touch and Nano navigators, refusal helpers on the command client, and two xfail tests. Regenerate the Nano backup/restore approval snapshots: the screen now uses nbgl_useCaseChoice and shows a small alert glyph.
A device refusal now returns 0x6985, which surfaced as a generic "failed" error banner. Tag the mapped error with its status word and treat the cancellation status apart: show an informational notice instead of an error.
Contributor
Code coverage reportPer-file coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #120 +/- ##
========================================
Coverage 81.88% 81.88%
========================================
Files 7 7
Lines 381 381
Branches 42 42
========================================
Hits 312 312
Misses 53 53
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes include