Fix test conditions#117
Merged
Merged
Conversation
The POPULATE build flag seeded password1/2/3 in app_main() on every app start, with no guard, so they piled up as duplicates on each launch. init_storage() now reports whether it just freshly initialized the storage (magic not yet set); the demo passwords are created only in that case. The behaviour stays fully gated by the POPULATE compile flag.
The save dialog was opened only after the device exchange (dump_metadatas), by which time the click's transient user activation had expired, so showSaveFilePicker threw "Must be handling a user gesture". Split saveJSON into pickSaveTarget() — called first, synchronously from the click handler while the activation is still valid — and writeJSON(), called once the backup data is ready. Falls back to a Blob/anchor download when the File System Access API is unavailable or refuses.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #117 +/- ##
========================================
Coverage 73.96% 73.96%
========================================
Files 7 7
Lines 361 361
Branches 41 41
========================================
Hits 267 267
Misses 88 88
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cedelavergne-ledger
force-pushed
the
cev/fix_test_conditions
branch
from
June 18, 2026 08:34
35edc39 to
ea04928
Compare
Contributor
Code coverage reportPer-file coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes include