Update webui#116
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #116 +/- ##
========================================
Coverage 73.96% 73.96%
========================================
Files 7 7
Lines 361 361
Branches 41 41
========================================
Hits 267 267
Misses 88 88
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Replace the legacy Create-React-App / React 17 / yarn / Node 16 stack with the reference stack used by app-openpgp: - Vite 8 + React 18 + pnpm 11 + Node 22 - Ledger lumen design system (@ledgerhq/lumen-ui-react + lumen-design-core, Tailwind 3 with ledgerLivePreset), following the bundled ai-rules - Vitest for the pure-logic units (charset mapping, metadata round-trip) - vite-plugin-node-polyfills for the Buffer API used by the APDU layer App rewritten with lumen (ThemeProvider/Banner/Tag/Button/...): Connect / Backup / Restore / Disconnect flow, in-app notification banners (replacing react-toastify) and an FAQ rebuilt with lumen tokens + react-markdown. Transport stays WebUSB (the Passwords app uses the generic USB interface). PasswordsManager keeps its APDU logic; disconnect() now releases the device and an onDisconnect callback surfaces physical unplugs. Icons reuse the device app glyph (glyphs/app_passwords_64px.gif): a white open-padlock for the in-page logo (on the dark canvas) and a white padlock on a black rounded tile for the favicon / PWA icons (visible on a white tab). The manifest previously pointed at a non-existent favicon.svg; fixed. Deploy workflow updated to pnpm + Node 22 + dist/; CNAME passwords.ledger.com preserved (Vite base "/"). Also refresh the stale support link in the FAQ and exclude pnpm-lock.yaml from codespell.
…f peaceiris Switch the Web UI deployment to GitHub's native Pages flow. PRs still build for validation; only pushes / manual runs deploy. The passwords.ledger.com custom domain is preserved (kept in the repo Pages settings and reinforced by dist/CNAME in the artifact).
cedelavergne-ledger
force-pushed
the
cev/update_webui
branch
from
June 18, 2026 06:20
3ddc99e to
f52d5ea
Compare
Contributor
Code coverage reportPer-file coverage
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate WebUI to Vite + react 18 + lumen