Skip to content

Relying on tests/setup_script.sh and not using a special docker test image#431

Draft
iartemov-ledger wants to merge 18 commits into
developfrom
test-docker-skip
Draft

Relying on tests/setup_script.sh and not using a special docker test image#431
iartemov-ledger wants to merge 18 commits into
developfrom
test-docker-skip

Conversation

@iartemov-ledger

@iartemov-ledger iartemov-ledger commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

schedule-simulated full run: https://github.com/LedgerHQ/app-bitcoin-new/actions/runs/22486514817 🟢

Some interesting figures:

  • "install test dependencies" step duration before: ~24.4s (24s, 21s, 20s, 26s, 31s)
  • "install test dependencies" step duration with this PRs (includes bitcoin core and dependencies installation): 50s (50s, 55s, 55s, 49s, 41s) so ~25 seconds of overhead, but we do not use a docker image and with ~15 minutes of total test execution run, its' about 3% time increase.

To fix the test let's wait for bitcoin core 31.0 in a couple of months that would contain a full musig2 support.

@iartemov-ledger iartemov-ledger changed the base branch from develop to bug_fixes_2026-02-18 February 26, 2026 14:49
@codecov-commenter

codecov-commenter commented Feb 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.45%. Comparing base (722aa6a) to head (95ef54e).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           bug_fixes_2026-02-18     #431   +/-   ##
=====================================================
  Coverage                 79.45%   79.45%           
=====================================================
  Files                        26       26           
  Lines                      3388     3388           
  Branches                    523      523           
=====================================================
  Hits                       2692     2692           
  Misses                      682      682           
  Partials                     14       14           
Flag Coverage Δ
unittests 79.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iartemov-ledger iartemov-ledger changed the title Test docker skip Relying on tests/setup_script.sh and not usinh a special docker test image Feb 26, 2026
@ledger-wiz-cspm-secret-detection

ledger-wiz-cspm-secret-detection Bot commented Feb 27, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations 34 Medium 1 Info
SAST Finding SAST Findings -
Software Management Finding Software Management Findings -
Total 34 Medium 1 Info

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@iartemov-ledger iartemov-ledger changed the title Relying on tests/setup_script.sh and not usinh a special docker test image Relying on tests/setup_script.sh and not using a special docker test image Feb 27, 2026
@iartemov-ledger iartemov-ledger force-pushed the bug_fixes_2026-02-18 branch 2 times, most recently from 5c782c1 to 8ff2b62 Compare February 27, 2026 13:00
Base automatically changed from bug_fixes_2026-02-18 to develop March 2, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants