Removing unneeded sudo#336
Draft
iartemov-ledger wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #336 +/- ##
========================================
Coverage 84.69% 84.69%
========================================
Files 17 17
Lines 2228 2228
========================================
Hits 1887 1887
Misses 341 341
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sjors
reviewed
Jul 30, 2025
| #!/bin/bash | ||
|
|
||
| sudo apt update -y && sudo apt install -y curl | ||
| apt update -y && sudo apt install -y curl |
Contributor
There was a problem hiding this comment.
It seems strange that only the sudo for apt update isn't needed. At least on my desktop Ubuntu it is needed generally.
If you're root than of course none of the sudo's are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.