fix: widen remote-fee median to parent ledger and full validations only#1237
Draft
LeJamon wants to merge 1 commit into
Draft
fix: widen remote-fee median to parent ledger and full validations only#1237LeJamon wants to merge 1 commit into
LeJamon wants to merge 1 commit into
Conversation
…ly (#1194) refreshRemoteFee sampled only the validated ledger's trusted validations and let trusted partials through, so the derived remote load fee drew from a smaller, differently-composed set than rippled. Fold in the parent ledger's validations and restrict to full validations to match LedgerMaster::fees / Validations::fees. Fixes #1194
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refreshRemoteFeenow mirrors rippled'sLedgerMaster/Validations::fees: the remote load-fee median is taken over the union of the validated ledger's and its parent ledger's trusted validations, and restricted to full validations only.collectValidationFeeshelper; parent hash is resolved viaGetLedgerByHash(ledgerID).ParentHash(), degrading gracefully to the current-ledger sample when the ledger isn't in history.Test plan
go test ./internal/consensus/adaptor/...(full package green)TestRefreshRemoteFee_ExcludesPartialValidations— trusted partial dropped from the medianTestRefreshRemoteFee_FoldsParentLedgerValidations— parent-ledger validations folded into the sampleTestRefreshRemoteFee_MedianOverTrustedValidationsfor the full-only filtergo vet+golangci-lint run --config .golangci.ymlcleanFixes #1194