Add generic TestLogger<T> for strongly-typed logging tests#6
Merged
Conversation
- Add TestLogger<T> that inherits from TestLogger and implements ILogger<T> - Enables unit tests to verify logging behavior for strongly-typed loggers - All existing TestLogger extension methods work automatically through inheritance - Add comprehensive tests using AwesomeAssertions to verify functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a generic TestLogger<T> for strongly-typed logging tests and adds a suite of unit tests to verify its behavior.
- Add
TestLogger<T>class inheriting fromTestLoggerand implementingILogger<T> - Create
GenericTestLoggerTests.csto cover core functionality, extension methods, clearing entries, shared state, andILogger<T>compatibility
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/LayeredCraft.StructuredLogging/Testing/TestingExtensions.cs | Added generic TestLogger<T> class with XML docs |
| test/LayeredCraft.StructuredLogging.Tests/Testing/GenericTestLoggerTests.cs | New tests validating TestLogger<T> behavior |
Comments suppressed due to low confidence (1)
test/LayeredCraft.StructuredLogging.Tests/Testing/GenericTestLoggerTests.cs:1
- The test file is missing the
using Xunit;andusing FluentAssertions;directives, which are required for the[Fact]attribute andShould()extension methods to compile.
using Microsoft.Extensions.Logging;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestLogger<T>class that inherits fromTestLoggerand implementsILogger<T>Test plan
ILogger<T>is expected🤖 Generated with Claude Code