Skip to content

Add condition to prevent packing of test projects in Directory.Build.…#3

Merged
ncipollina merged 4 commits into
mainfrom
feature/unit-test-package
Jun 10, 2025
Merged

Add condition to prevent packing of test projects in Directory.Build.…#3
ncipollina merged 4 commits into
mainfrom
feature/unit-test-package

Conversation

@ncipollina

Copy link
Copy Markdown
Contributor

…props

🚀 Pull Request

📋 Summary

Briefly describe what this PR does and why it's needed.


✅ Checklist

  • My changes build cleanly
  • I’ve added/updated relevant tests
  • I’ve added/updated documentation or README
  • I’ve followed the coding style for this project
  • I’ve tested the changes locally (if applicable)

🧪 Related Issues or PRs

Closes #...


💬 Notes for Reviewers

Any specific areas to look at, known issues, or follow-up work.

@ncipollina
ncipollina requested a review from Copilot June 10, 2025 12:51

This comment was marked as outdated.

@ncipollina
ncipollina requested a review from Copilot June 10, 2025 12:57

This comment was marked as outdated.

@ncipollina
ncipollina requested a review from Copilot June 10, 2025 13:01

This comment was marked as outdated.

…redLogging.Tests.csproj

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ncipollina
ncipollina requested a review from Copilot June 10, 2025 13:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prevents test projects from being packed by adding a condition that sets the packable property to false in the build configuration.

  • Adds an IsTestProject property to the test project’s .csproj
  • Introduces a conditional PropertyGroup in Directory.Build.props to disable packing for test projects

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/LayeredCraft.StructuredLogging.Tests/LayeredCraft.StructuredLogging.Tests.csproj Added IsTestProject property to mark test projects
Directory.Build.props Added conditional PropertyGroup to disable project packing for test projects

@ncipollina
ncipollina merged commit b0d34ff into main Jun 10, 2025
1 check passed
@ncipollina
ncipollina deleted the feature/unit-test-package branch June 10, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants